Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New PKI API to generate and sign a CRL based on input data #18040

Merged
merged 5 commits into from
Nov 22, 2022
Merged

New PKI API to generate and sign a CRL based on input data #18040

merged 5 commits into from
Nov 22, 2022

Conversation

stevendpclark
Copy link
Contributor

  • Add a new PKI API that allows an end-user to feed in all the information required to generate and sign a CRL by a given issuer.
  • This is pretty powerful API allowing an escape hatch for 3rd parties to craft customized CRLs with extensions based on their individual needs

@stevendpclark stevendpclark added this to the 1.13.0-rc1 milestone Nov 18, 2022
@stevendpclark stevendpclark requested review from kitography, cipherboy and a team November 18, 2022 15:45
cipherboy
cipherboy approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@cipherboy cipherboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

builtin/logical/pki/path_resign_crls.go Outdated Show resolved Hide resolved
@stevendpclark
New PKI API to generate and sign a CRL based on input data
d5c93df 
 - Add a new PKI API that allows an end-user to feed in all the
   information required to generate and sign a CRL by a given issuer.
 - This is pretty powerful API allowing an escape hatch for 3rd parties
   to craft customized CRLs with extensions based on their individual
   needs
@stevendpclark
Add api-docs and error if reserved extension is provided as input
43b8ae6
@stevendpclark
Fix copy/paste error in Object Identifier constants
f57df6a
@stevendpclark
Return nil on errors instead of partially filled slices
02a9761
@stevendpclark stevendpclark force-pushed the stevendpclark/vault-9718-sign-rev-list branch from a19d7c2 to 02a9761 Compare November 22, 2022 15:19
@stevendpclark stevendpclark merged commit 9fcb17c into main Nov 22, 2022
@stevendpclark stevendpclark deleted the stevendpclark/vault-9718-sign-rev-list branch November 22, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cipherboy cipherboy cipherboy approved these changes

@kitography kitography Awaiting requested review from kitography

Assignees
No one assigned
Labels
secret/pki
Projects
None yet
Milestone
1.13.0-rc1
Development

Successfully merging this pull request may close these issues.
2 participants
@stevendpclark @cipherboy